1027253 - [Rocketbar][Settings] Missing grey subheaders in the settings for homescreen

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: Search_App_v0_6.pdf

see spec

Comment 2

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: 2014-06-18-12-44-49.png

STR: 
1. go to settings -> homescreen
2. look for subheaders

Expected: see spec
Actual: none

Gaia      83844c7679b3b9f6e7f1116c1eeec2d1e7a64eec
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/55679dc2e72b
BuildID   20140618000202
Version   32.0a2
ro.build.version.incremental=108
ro.build.date=Tue Jun 10 19:40:40 CST 2014
Flame

Comment 3

[Cristian Rodriguez (:crdlc)]

Attachment: homescreen settings and sub headers.png

Thanks

Comment 4

[Cristian Rodriguez (:crdlc)]

Attachment: Github pull request

Thanks

Comment 5

[Cristian Rodriguez (:crdlc)]

Hi Jason,

   I have to add two new strings in the locale file, which flag should I add?

Thanks a lot

Comment 6

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8447044 [details]
Github pull request

Looks good to me, thanks for your help :]

r+

Comment 7

[Cristian Rodriguez (:crdlc)]

Thanks to you

(In reply to EJ Chen [:eragonj][:小龍哥] from comment #6)
> Comment on attachment 8447044 [details]
> Github pull request
> 
> Looks good to me, thanks for your help :]
> 
> r+

Comment 8

[Peter La]

Comment on attachment 8447043 [details]
homescreen settings and sub headers.png

Looks good. :)

Comment 9

[Cristian Rodriguez (:crdlc)]

Merged in master:

https://github.com/crdlc/gaia/commit/858bb0ca2439be1048b8824f3214d2e1321ac943

Comment 10

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8447044 [details]
Github pull request

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): no regression
[User impact] if declined: view no aligned with the rest of settings' views
[Testing completed]: no needed, ux+. Two new sub headers was added to homescreen settings view
[Risk to taking this patch] (and alternatives if risky): close to null
[String changes made]: yes, two new string was added. https://github.com/crdlc/gaia/commit/858bb0ca2439be1048b8824f3214d2e1321ac943#diff-d32b8deaad757f82f46fa1f7d2c9b528R611

Comment 11

[bhavana bajaj [:bajaj]]

We are way past the string freeze on 2.0 so please submit an alternative without string changes if this needs to in 2.0. 

Reviewers including folks on UX please keep the string freeze in mind before +'ing these patches.

Comment 12

[Elie]

Attachment: IMAG0559.jpg

This issue has been successfully verified on Flame 2.1:
Gaia-Rev        5372b675e018b6aac97d95ff5db8d4bd16addb9b
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/f34377ae402b
Build-ID        20141127001201
Version         34.0
Device-Name     flame
FW-Release      4.4.2