Closed
Bug 1027253
Opened 10 years ago
Closed 10 years ago
[Rocketbar][Settings] Missing grey subheaders in the settings for homescreen
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(b2g-v2.0 affected, b2g-v2.1 fixed)
RESOLVED
FIXED
2.0 S5 (4july)
People
(Reporter: nhirata, Assigned: crdlc)
References
Details
(Keywords: late-l10n, Whiteboard: [systemsfe])
Attachments
(5 files)
3.01 MB,
application/pdf
|
Details | |
34.15 KB,
image/png
|
Details | |
20.03 KB,
image/png
|
pla
:
ui-review+
|
Details |
190 bytes,
text/html
|
eragonj
:
review+
bajaj
:
approval-gaia-v2.0-
|
Details |
1.61 MB,
image/jpeg
|
Details |
No description provided.
Reporter | ||
Comment 1•10 years ago
|
||
see spec
Reporter | ||
Comment 2•10 years ago
|
||
STR: 1. go to settings -> homescreen 2. look for subheaders Expected: see spec Actual: none Gaia 83844c7679b3b9f6e7f1116c1eeec2d1e7a64eec Gecko https://hg.mozilla.org/releases/mozilla-aurora/rev/55679dc2e72b BuildID 20140618000202 Version 32.0a2 ro.build.version.incremental=108 ro.build.date=Tue Jun 10 19:40:40 CST 2014 Flame
Reporter | ||
Updated•10 years ago
|
status-b2g-v2.0:
--- → affected
Updated•10 years ago
|
Blocks: vertical-home-next
QA Whiteboard: [VH-FL-blocking-][VH-FC-blocking-]
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Assignee | ||
Comment 5•10 years ago
|
||
Hi Jason, I have to add two new strings in the locale file, which flag should I add? Thanks a lot
Flags: needinfo?(jsmith)
Comment 6•10 years ago
|
||
Comment on attachment 8447044 [details]
Github pull request
Looks good to me, thanks for your help :]
r+
Attachment #8447044 -
Flags: review?(ejchen) → review+
Assignee | ||
Comment 7•10 years ago
|
||
Thanks to you (In reply to EJ Chen [:eragonj][:小龍哥] from comment #6) > Comment on attachment 8447044 [details] > Github pull request > > Looks good to me, thanks for your help :] > > r+
Assignee | ||
Updated•10 years ago
|
status-b2g-v2.1:
--- → affected
Updated•10 years ago
|
Whiteboard: [systemsfe]
Comment on attachment 8447043 [details]
homescreen settings and sub headers.png
Looks good. :)
Attachment #8447043 -
Flags: ui-review?(pla) → ui-review+
Assignee | ||
Comment 9•10 years ago
|
||
Merged in master: https://github.com/crdlc/gaia/commit/858bb0ca2439be1048b8824f3214d2e1321ac943
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•10 years ago
|
Assignee | ||
Comment 10•10 years ago
|
||
Comment on attachment 8447044 [details] Github pull request NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] [Bug caused by] (feature/regressing bug #): no regression [User impact] if declined: view no aligned with the rest of settings' views [Testing completed]: no needed, ux+. Two new sub headers was added to homescreen settings view [Risk to taking this patch] (and alternatives if risky): close to null [String changes made]: yes, two new string was added. https://github.com/crdlc/gaia/commit/858bb0ca2439be1048b8824f3214d2e1321ac943#diff-d32b8deaad757f82f46fa1f7d2c9b528R611
Attachment #8447044 -
Flags: approval-gaia-v2.0?(bbajaj)
Updated•10 years ago
|
Target Milestone: --- → 2.0 S5 (4july)
Comment 11•10 years ago
|
||
We are way past the string freeze on 2.0 so please submit an alternative without string changes if this needs to in 2.0. Reviewers including folks on UX please keep the string freeze in mind before +'ing these patches.
Updated•10 years ago
|
Attachment #8447044 -
Flags: approval-gaia-v2.0?(bbajaj) → approval-gaia-v2.0-
Updated•10 years ago
|
Comment 12•10 years ago
|
||
This issue has been successfully verified on Flame 2.1: Gaia-Rev 5372b675e018b6aac97d95ff5db8d4bd16addb9b Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/f34377ae402b Build-ID 20141127001201 Version 34.0 Device-Name flame FW-Release 4.4.2
You need to log in
before you can comment on or make changes to this bug.
Description
•